Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deployment filter for devices #1914

Merged
merged 2 commits into from
Feb 21, 2025
Merged

Add deployment filter for devices #1914

merged 2 commits into from
Feb 21, 2025

Conversation

nshoes
Copy link
Contributor

@nshoes nshoes commented Feb 21, 2025

No description provided.

@nshoes nshoes requested review from joshk and jjcarstens February 21, 2025 00:43
@nshoes
Copy link
Contributor Author

nshoes commented Feb 21, 2025

This change displays the deployment id in the URL when filtering a device's deployment, e.g. /devices?deployment_id=2. We normally other identifiers as slugs throughout the app, should we do the same here? Filter on deployment.name instead?

jjcarstens
jjcarstens approved these changes Feb 21, 2025
View reviewed changes
Copy link
Collaborator

@jjcarstens jjcarstens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are okay with deployment_id being a param in the path only filled by code, then we're good. I don't have strong opinions. But I also don't think we expose the deployment_id anywhere in the UI

@nshoes nshoes merged commit 1c1357d into main Feb 21, 2025
2 checks passed
@nshoes nshoes deleted the filter-devices-by-deployment branch February 21, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjcarstens jjcarstens jjcarstens approved these changes

@joshk joshk Awaiting requested review from joshk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nshoes @jjcarstens